Add .rcond() and .rcond_into() #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also changes the character representations of `NormType` to capital letters to be compatible with `*gecon`.
termoshtt
approved these changes
Oct 26, 2017
tests/solve.rs
Outdated
| @@ -5,6 +5,7 @@ extern crate num_traits; | |||
|
|
|||
| use ndarray::*; | |||
| use ndarray_linalg::*; | |||
| use ndarray_linalg::lapack_traits::opnorm::NormType; | |||
There was a problem hiding this comment.
use opnorm_one. not to import lapack_traits
src/solve.rs
Outdated
| A::rcond( | ||
| self.a.layout()?, | ||
| self.a.as_allocated()?, | ||
| self.a.opnorm(NormType::One)?, |
src/lapack_traits/opnorm.rs
Outdated
| @@ -8,9 +8,9 @@ use types::*; | |||
|
|
|||
| #[repr(u8)] | |||
| pub enum NormType { | |||
There was a problem hiding this comment.
move to src/lapack_traits/mod.rs like UPLO
|
Good catch on the I moved |
termoshtt
added a commit
that referenced
this pull request
Oct 26, 2017
|
Thanks!
I make it public. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit exposes the LAPACK
*geconroutines through.rcond()and.rcond_into()methods. It also changes the character representations ofNormTypeto capital letters to be compatible with*gecon.